added warning messages when unable to remap the interface properly in Joint State Broadcaster. #2082
Open
sviridovm wants to merge 5 commits intoros-controls:masterfrom
Open
added warning messages when unable to remap the interface properly in Joint State Broadcaster. #2082sviridovm wants to merge 5 commits intoros-controls:masterfrom
sviridovm wants to merge 5 commits intoros-controls:masterfrom
Conversation
github-actions
bot
requested review from
Juliaj,
MarqRazz,
aprotyas,
christophfroehlich and
xguay
sviridovm
changed the title
saikishor
requested changes
Dec 27, 2025
| { | ||
| RCLCPP_WARN( | ||
| get_node()->get_logger(), | ||
| "Interface '%s' of joint '%s' is not mapped to any joint state field. The default value %s will be used.", |
Member
There was a problem hiding this comment.
Print the proper double default value
Contributor
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
thedevmystic
suggested changes
Apr 1, 2026
Comment on lines
+288
to
+290
| // Moreover, when there is not even the default interface (position, velocity, effort), | ||
| // then it should also print that it is not present and NaN's will be obtained in the | ||
| // respective field. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Moreover, when there is not even the default interface (position, velocity, effort), | |
| // then it should also print that it is not present and NaN's will be obtained in the | |
| // respective field. | |
| // If default interfaces (pos/vel/eff) are missing, log a warning and return NaN in | |
| // the fields. |
Currently it's too wordy than necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added warn messages when an interface remapping does not occur.
Added warn messages when default interface is not present and thus there will be default NaN values.
Fixes issue #1776